Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider/aws: Renaming option_settings attribute to setting. Added test to verify that settings are applied to template. #6043

Merged
merged 1 commit into from
Apr 6, 2016
Merged

provider/aws: Renaming option_settings attribute to setting. Added test to verify that settings are applied to template. #6043

merged 1 commit into from
Apr 6, 2016

Conversation

dharrisio
Copy link
Contributor

This updates the remaining uses of option_settings to setting. Also added test to verify settings are being set.
#6035

TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSBeanstalkConfigurationTemplate -timeout 120m
=== RUN   TestAccAWSBeanstalkConfigurationTemplate_basic
--- PASS: TestAccAWSBeanstalkConfigurationTemplate_basic (15.32s)
=== RUN   TestAccAWSBeanstalkConfigurationTemplate_VPC
--- PASS: TestAccAWSBeanstalkConfigurationTemplate_VPC (18.59s)
=== RUN   TestAccAWSBeanstalkConfigurationTemplate_Setting
--- PASS: TestAccAWSBeanstalkConfigurationTemplate_Setting (13.11s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    47.023s

@dharrisio
provider/aws: Renaming option_settings attribute to setting. Adde…
b1bdd1b 
…d test to verify that settings are applied to template.

ref hashicorp#6035
@catsby catsby merged commit e698822 into hashicorp:master Apr 6, 2016
@stack72
Copy link
Contributor

stack72 commented Apr 6, 2016

Hi @dharrisio

Do you think we should add in the old option_setting param and then add the deprecate message?

P.

@catsby
Copy link
Contributor

catsby commented Apr 6, 2016

Thanks! Sorry about that 😱

@catsby catsby mentioned this pull request Apr 6, 2016
Closed
@catsby
Copy link
Contributor

catsby commented Apr 6, 2016

@stack72 and I discussed his question, we're all good here 👍

@dharrisio dharrisio deleted the aws-elastic-beanstalk-config-template-settings-tests branch April 6, 2016 16:53
@dharrisio dharrisio mentioned this pull request Apr 20, 2016
Closed
@ghost
Copy link

ghost commented Apr 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dharrisio @stack72 @catsby